[review v3] [gdb/symtab] Prefer var def over decl

[Tom de Vries (Code Review)]

Tom de Vries has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/29
......................................................................


Patch Set 3:

(2 comments)

Thanks for the comments, updated the patch set.

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/29/2/gdb/block.c 
File gdb/block.c:

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/29/2/gdb/block.c@737 
PS2, Line 737: /* Return true if symbol A is a better match than symbol B for DOMAIN.  */
> The comment is a bit misleading. […]
Done


https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/29/2/gdb/testsuite/gdb.dwarf2/varval.exp 
File gdb/testsuite/gdb.dwarf2/varval.exp:

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/29/2/gdb/testsuite/gdb.dwarf2/varval.exp@209 
PS2, Line 209: 
> Spurious new line?
Done