[review] Don't make an extra copy + allocation of the demangled name

[Luis Machado (Code Review)]

Luis Machado has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/132
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

Although the obstack manipulation bits are a bit odd with the offsets and potentially less than ideal documentation, this looks reasonable to me. Only a couple nits in formatting.

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/132/1/gdb/symtab.c 
File gdb/symtab.c:

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/132/1/gdb/symtab.c@718 
PS1, Line 718:   char* demangled;
Usual style is "char *demangled;" i think. Although there is one offender in symtab.c already.


https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/132/1/gdb/symtab.c@887 
PS1, Line 887: 	 
Something odd here? Whitespace?