[review v5] Store the mangled name as a string_view
Christian Biesinger (Code Review)
gerrit@gnutoolchain-gerrit.osci.io
Mon Oct 21 23:13:00 GMT 2019
Christian Biesinger has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/37
......................................................................
Patch Set 5:
(1 comment)
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/37/3/gdb/symtab.c
File gdb/symtab.c:
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/37/3/gdb/symtab.c@891
PS3, Line 891: + demangled_len + 1));
> Pedantically, since demangled_name_entry is now a non-POD, we should run the constructor here and th [â¦]
Sure, happy to add a delete function -- I have another pending patch that also needs one (https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/132).
Done.
More information about the Gdb-patches
mailing list