[review] gdb: Ensure that !(a < a) is true in sort_cmp on obj_section objects

Simon Marchi (Code Review) gerrit@gnutoolchain-gerrit.osci.io
Mon Oct 21 17:34:00 GMT 2019


Simon Marchi has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/177
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/177/1/gdb/objfiles.c 
File gdb/objfiles.c:

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/177/1/gdb/objfiles.c@1055 
PS1, Line 1055: does check that '!(a < a)'
Not sure if it's worth mentioning it, but to be exact, std::sort check when compiling with libstdc++'s debug mode.





More information about the Gdb-patches mailing list