[review] Replace some more qsort calls with std::sort

Simon Marchi (Code Review) gerrit@gnutoolchain-gerrit.osci.io
Sat Oct 19 04:32:00 GMT 2019


Simon Marchi has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/131
......................................................................


Patch Set 2:

(1 comment)

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/131/1/gdb/breakpoint.c 
File gdb/breakpoint.c:

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/131/1/gdb/breakpoint.c@522 
PS1, Line 522: /* Array is sorted by bp_location_is_less_than - primarily by the ADDRESS.  */
> When you're logged in, you can set diff preferences using the "gear" icon on the right, where you ca […]
Tom, I have made a change that should make the line length 80 columns for all users that haven't set it themselves.  You should therefore see a guide at column 80.  Please tell me if that worked (unless you have already changed it yourself, then we'll need to ask somebody else).





More information about the Gdb-patches mailing list