[review] [gdb/symtab] Prefer var def over decl

[Luis Machado (Code Review)]

Luis Machado has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/29
......................................................................


Patch Set 2: Code-Review+1

(2 comments)

I've noticed a couple nits.

If PR91507 is fixed, do we need to patch GDB up? Or do we want to adapt GDB to the broken output from older GCC as well?

I'm inclined to at least add some comment to the code stating GCC's broken behavior and why we're fixing it in this particular way.

Otherwise this looks good to me.

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/29/2/gdb/block.c 
File gdb/block.c:

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/29/2/gdb/block.c@737 
PS2, Line 737: /* Return true if symbol A is a better match than symbol B for DOMAIN.  */
The comment is a bit misleading. Maybe "Return symbol A if it is a better match than symbol B for DOMAIN.  Otherwise return B."

It seems the default, if everything fails, is to return A? Maybe add that to the comment as well.


https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/29/2/gdb/testsuite/gdb.dwarf2/varval.exp 
File gdb/testsuite/gdb.dwarf2/varval.exp:

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/29/2/gdb/testsuite/gdb.dwarf2/varval.exp@209 
PS2, Line 209: 
Spurious new line?