[review] Add a fast_hash function in common-utils
Christian Biesinger (Code Review)
gerrit@gnutoolchain-gerrit.osci.io
Wed Oct 16 13:09:00 GMT 2019
Christian Biesinger has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/38
......................................................................
Uploaded patch set 2.
(2 comments)
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/38/1/gdb/utils.h
File gdb/utils.h:
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/38/1/gdb/utils.h@572
PS1, Line 572: extern unsigned int fast_hash (const char* str, size_t len);
> You need a comment describing what the function does here.
Done
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/38/1/gdb/utils.c
File gdb/utils.c:
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/38/1/gdb/utils.c@3439
PS1, Line 3439: unsigned int
> And you need a simple comment here saying [â¦]
Done
More information about the Gdb-patches
mailing list