[review] Add a fast_hash function in common-utils

[Sergio Durigan Junior (Code Review)]

Sergio Durigan Junior has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/38
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

LGTM assuming that the two minor nits are fixed.  Thanks!

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/38/1/gdb/utils.h 
File gdb/utils.h:

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/38/1/gdb/utils.h@572 
PS1, Line 572: extern unsigned int fast_hash (const char* str, size_t len);
You need a comment describing what the function does here.


https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/38/1/gdb/utils.c 
File gdb/utils.c:

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/38/1/gdb/utils.c@3439 
PS1, Line 3439: unsigned int
And you need a simple comment here saying

    /* See utils.h.  */