[review] Create xml-builtin.h to declare xml_builtins

Christian Biesinger (Code Review) gerrit@gnutoolchain-gerrit.osci.io
Tue Oct 15 22:36:00 GMT 2019


Christian Biesinger has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/25
......................................................................


Patch Set 2:

> Patch Set 1:
> 
> (1 comment)
> 
> Thanks for the patch.
> 
> I'm not totally sure that the new .h belongs in gdb.  On the one hand, I think we want to try to keep gdb and gdbserver separate to some extent, and only share via gdbsupport.  On the other hand, I broke that rule already with alloc.c.

Well xml-builtin.c is created in gdb/ and compiled by both... Do you want me to move both to gdbsupport?

> I did find a nit though.

Thanks, fixed.




More information about the Gdb-patches mailing list