Change in binutils-gdb[master]: Create xml-builtin.h to declare xml_builtins

[Tom Tromey (Code Review)]

Tom Tromey has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/25
......................................................................


Patch Set 1:

(1 comment)

Thanks for the patch.

I'm not totally sure that the new .h belongs in gdb.  On the one hand, I think we want to try to keep gdb and gdbserver separate to some extent, and only share via gdbsupport.  On the other hand, I broke that rule already with alloc.c.

I did find a nit though.

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/25/1//COMMIT_MSG 
Commit Message:

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/25/1//COMMIT_MSG@22 
PS1, Line 22: 	* features/feature_to_c.sh: Add an include for xml-buoltin.h
Typo, should be "xml-builtin.h"



-- 
To view, visit https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/25
To unsubscribe, or for help writing mail filters, visit https://gnutoolchain-gerrit.osci.io/r/settings