Change in binutils-gdb[master]: Add initial compile command support to RISC-V port.

[Tom Tromey (Code Review)]

Tom Tromey has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/42
......................................................................


Patch Set 1:

(1 comment)

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/42/1/gdb/riscv-tdep.c 
File gdb/riscv-tdep.c:

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/42/1/gdb/riscv-tdep.c@3070 
PS1, Line 3070:   char string[64];
> I think using std::string and then just 'string += "some text";' would be preferred.

I sent a patch to change this gdbarch function to return std::string, which should make this a bit nicer.



-- 
To view, visit https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/42
To unsubscribe, or for help writing mail filters, visit https://gnutoolchain-gerrit.osci.io/r/settings