Change in binutils-gdb[master]: Change iterate_over_breakpoints to take a function_view
Christian Biesinger (Code Review)
gerrit@gnutoolchain-gerrit.osci.io
Tue Oct 15 08:43:00 GMT 2019
Christian Biesinger has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/21
......................................................................
Uploaded patch set 3.
(6 comments)
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/21/2/gdb/breakpoint.c
File gdb/breakpoint.c:
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/21/2/gdb/breakpoint.c@15131
PS2, Line 15131: iterate_over_breakpoints
: (gdb::function_view<bool (breakpoint *)> callback)
> This would fit on a single line.
Done
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/21/2/gdb/dummy-frame.c
File gdb/dummy-frame.c:
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/21/2/gdb/dummy-frame.c@169
PS2, Line 169: iterate_over_breakpoints ([dummy] (breakpoint* bp)
> Same comment about formatting as in py-finishbreakpoint.c.
Done
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/21/2/gdb/guile/scm-breakpoint.c
File gdb/guile/scm-breakpoint.c:
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/21/2/gdb/guile/scm-breakpoint.c@551
PS2, Line 551: ([&] (breakpoint *bp) { return bpscm_build_bp_list(bp, &list); })
> For readability, I'd like if you took that out of the "if". Either: [â¦]
Done; I chose to remove the if.
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/21/2/gdb/python/py-breakpoint.c
File gdb/python/py-breakpoint.c:
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/21/2/gdb/python/py-breakpoint.c@909
PS2, Line 909: ([&] (breakpoint *bp) { return build_bp_list(bp, list.get ()); }) != NULL)
> Same comment about formatting as in scm-breakpoint. [â¦]
Done
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/21/2/gdb/python/py-finishbreakpoint.c
File gdb/python/py-finishbreakpoint.c:
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/21/2/gdb/python/py-finishbreakpoint.c@386
PS2, Line 386: iterate_over_breakpoints ([&] (breakpoint *bp) {
: return bpfinishpy_detect_out_scope_cb
: (bp, bs == NULL ? NULL : bs->breakpoint_at); });
> I was told before to place the curly braces of the lambda like this, to mimic how we format scopes: [â¦]
Done, thanks.
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/21/2/gdb/python/py-finishbreakpoint.c@399
PS2, Line 399: iterate_over_breakpoints ([&] (breakpoint *bp) {
> Same.
Done
--
To view, visit https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/21
To unsubscribe, or for help writing mail filters, visit https://gnutoolchain-gerrit.osci.io/r/settings
More information about the Gdb-patches
mailing list