Change in binutils-gdb[master]: [gdb/symtab] Prefer var def over decl

[Tom de Vries (Code Review)]

Tom de Vries has posted comments on this change. ( https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/29 )

Change subject: [gdb/symtab] Prefer var def over decl
......................................................................


Patch Set 2:

(2 comments)

Added missing function comments.

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/29/1/gdb/block.c 
File gdb/block.c:

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/29/1/gdb/block.c@729 
PS1, Line 729: best_symbol (struct symbol *a, const domain_enum domain)
> All functions should have a header comment: https://sourceware. […]
Done


https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/29/1/gdb/block.c@736 
PS1, Line 736: better_symbol (struct symbol *a, struct symbol *b, const domain_enum domain)
> Again, needs a comment.
Done



-- 
To view, visit https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/29
To unsubscribe, or for help writing mail filters, visit https://gnutoolchain-gerrit.osci.io/r/settings

Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Id92326cb8ef9903b121ef9e320658eb565d0f5a9
Gerrit-Change-Number: 29
Gerrit-PatchSet: 2
Gerrit-Owner: Tom de Vries <tdevries@suse.de>
Gerrit-Reviewer: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-Reviewer: Tom de Vries <tdevries@suse.de>
Gerrit-Comment-Date: Mon, 14 Oct 2019 16:50:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-MessageType: comment