[PATCH] Move declaration of breakpoint_chain to the header.

Christian Biesinger via gdb-patches gdb-patches@sourceware.org
Wed Oct 9 19:04:00 GMT 2019


On Wed, Oct 9, 2019 at 12:43 PM Tom Tromey <tom@tromey.com> wrote:
>
> >>>>> "Christian" == Christian Biesinger via gdb-patches <gdb-patches@sourceware.org> writes:
>
> Christian> TUI was using it.
> Christian> gdb/ChangeLog:
>
> Christian> 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
>
> Christian>      * breakpoint.c (breakpoint_chain): Move comment to header.
> Christian>      * breakpoint.h (breakpoint_chain): Declare.
> Christian>      * tui/tui-winsource.c (tui_source_window_base::update_breakpoint_info):
> Christian>      Remove declaration of breakpoint_chain.
>
> I think it would be preferable to change the TUI to use
> iterate_over_bp_locations or iterate_over_breakpoints instead;
> then make breakpoint_chain static.

Thanks, I will send an updated version in a moment. It will be a patch
set because I'm also changing iterate_over_breakpoints to take a
function_view.

Christian



More information about the Gdb-patches mailing list