[PATCH] Include xml-support.h to get a variable declaration

Tom Tromey tom@tromey.com
Wed Oct 9 17:47:00 GMT 2019


>>>>> "Christian" == Christian Biesinger via gdb-patches <gdb-patches@sourceware.org> writes:

Christian> Instead of declaring xml_builtin as an extern variable
Christian> in the .c file.

Christian> gdb/gdbserver/ChangeLog:

Christian> 2019-10-07  Christian Biesinger  <cbiesinger@google.com>

Christian> 	* server.c (get_features_xml): Remove declaration of xml_builtin
Christian> 	in favor of including xml-support.h.

I don't think we want to include xml-support.h in gdbserver.

Maybe the xml_builtin can be declared somewhere else instead.
It's only defined in generated files according to the comment.

Tom



More information about the Gdb-patches mailing list