[PATCH] Add missing includes to gdb_assert.h and gdb_string_view.h

Tom Tromey tom@tromey.com
Wed Oct 2 15:56:00 GMT 2019


>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:

Simon> In any case, I don't really see any downside going with the "include what
Simon> you use" route, so this patch would LGTM.  I'm just curious to see if others
Simon> have any objection to this, so please wait a bit before merging it.

It seems fine to me.  A redundant include is pretty harmless overall; I
think the main include problem is a "new" include that isn't needed, as
these add to compilation time.

Tom



More information about the Gdb-patches mailing list