[PATCHv5 0/3] Remove some uses of VEC

Andrew Burgess andrew.burgess@embecosm.com
Tue Oct 1 11:42:00 GMT 2019


Thank you to Markus for the continued feedback.  This revision
addresses the points raised against v4.

  - Removed helper functions, I'm convinved that the std::vector
    pointer should not be null at the places we dereference it.

  - Streamlined the removal of the vec.h header, originally I moved
    the include in the first patch, and removed it in the second
    patch.  Now I leave it alone in the first patch, and delete it in
    the second.

  - I've NOT addressed the long line feedback, one line was 80+ long,
    while the other was 79.  I'd prefer to keep both of these split
    over two lines.

  - Patch #3 is unchanged.

Thanks,
Andrew

--

Andrew Burgess (3):
  gdb: Remove a VEC from gdbsupport/btrace-common.h
  gdb: Change a VEC to std::vector in btrace.{c,h}
  gdb: Remove a use of VEC from dwarf2read.{c,h}

 gdb/ChangeLog                  | 47 ++++++++++++++++++++
 gdb/btrace.c                   | 98 +++++++++++++++++++-----------------------
 gdb/btrace.h                   |  5 +--
 gdb/dwarf2read.c               | 17 ++++----
 gdb/dwarf2read.h               |  3 --
 gdb/gdbserver/ChangeLog        |  5 +++
 gdb/gdbserver/linux-low.c      |  8 +---
 gdb/gdbsupport/btrace-common.c | 18 ++++----
 gdb/gdbsupport/btrace-common.h | 19 ++++----
 gdb/nat/linux-btrace.c         | 16 +++----
 10 files changed, 135 insertions(+), 101 deletions(-)

-- 
2.14.5



More information about the Gdb-patches mailing list