[review] [ARM, sim] Fix build error and warnings
Simon Marchi (Code Review)
gerrit@gnutoolchain-gerrit.osci.io
Wed Nov 27 15:36:00 GMT 2019
Simon Marchi has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/726
......................................................................
Patch Set 1:
(2 comments)
| --- sim/arm/arminit.c
| +++ sim/arm/arminit.c
| @@ -36,15 +36,19 @@ void ARMul_Abort (ARMul_State * state, ARMword address);
| unsigned ARMul_MultTable[32] =
| { 1, 2, 2, 3, 3, 4, 4, 5, 5, 6, 6, 7, 7, 8, 8, 9, 9,
| 10, 10, 11, 11, 12, 12, 13, 13, 14, 14, 15, 15, 16, 16, 16
| };
| ARMword ARMul_ImmedTable[4096]; /* immediate DP LHS values */
| char ARMul_BitList[256]; /* number of bits in a byte table */
|
| +/* The PC pipeline value depends on whether ARM
| + or Thumb instructions are being executed. */
| +ARMword isize;
PS1, Line 45:
How does moving this here help?
There is a declaration of isize in armemu.h, and isize was defined in
armemu.c, so I don't immediately see what's wrong with the existing
code.
| +
| /***************************************************************************\
| * Call this routine once to set up the emulator's tables. *
| \***************************************************************************/
|
| void
| ARMul_EmulateInit (void)
| {
| unsigned long i, j;
| --- sim/arm/wrapper.c
| +++ sim/arm/wrapper.c
| @@ -126,16 +126,16 @@ };
|
| union maverick_acc_regs
| {
| long double ld; /* Acc registers are 72-bits. */
| };
|
| -struct maverick_regs DSPregs[16];
| -union maverick_acc_regs DSPacc[4];
| -ARMword DSPsc;
| +extern struct maverick_regs DSPregs[16];
PS1, Line 132:
Would it be possible to place these declarations in a header file
shared between all files that use these variables? Otherwise, there's
always the risk that they get out of sync.
| +extern union maverick_acc_regs DSPacc[4];
| +extern ARMword DSPsc;
|
| static void
| init (void)
| {
| static int done;
|
| if (!done)
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I21db699d3b61b2de8c44053e47be4387285af28f
Gerrit-Change-Number: 726
Gerrit-PatchSet: 1
Gerrit-Owner: Luis Machado <luis.machado@linaro.org>
Gerrit-Reviewer: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-CC: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Comment-Date: Wed, 27 Nov 2019 15:36:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
More information about the Gdb-patches
mailing list