[review v6] [Debugging output] Make remote packet truncation length adjustable
Luis Machado (Code Review)
gerrit@gnutoolchain-gerrit.osci.io
Mon Nov 25 13:33:00 GMT 2019
Luis Machado has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/691
......................................................................
Patch Set 6:
(1 comment)
Thanks for the review. I'll push this later today.
| --- /dev/null
| +++ /COMMIT_MSG
| @@ -1,0 +23,19 @@ gdb/ChangeLog:
| +2019-11-21 Luis Machado <luis.machado@linaro.org>
| +
| + * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
| + * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
| + (remote_packet_max_chars): New static global.
| + (show_remote_packet_max_chars): New function.
| + (remote_target::putpkt_binary): Adjust to use new
| + remote-packet-max-chars option.
| + (remote_target::getpkt_or_notif_sane_1): Likewise.
| + (_initialize_remote): Register new remote_packet_max_chars option.
PS5, Line 32:
Ah, got it. Sorry, i missed this in e-mail form for some reason.
| +
| +gdb/doc/ChangeLog:
| +
| +2019-11-21 Luis Machado <luis.machado@linaro.org>
| +
| + * gdb.texinfo (Debugging Output): Document set debug
| + remote-packet-max-chars.
| +
| +Signed-off-by: Luis Machado <luis.machado@linaro.org>
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I2e871b37bfcaa6376537c3fe3db8f016dd806a7c
Gerrit-Change-Number: 691
Gerrit-PatchSet: 6
Gerrit-Owner: Luis Machado <luis.machado@linaro.org>
Gerrit-Reviewer: Luis Machado <luis.machado@linaro.org>
Gerrit-Reviewer: Pedro Alves <palves@redhat.com>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-Comment-Date: Mon, 25 Nov 2019 13:33:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Pedro Alves <palves@redhat.com>
Gerrit-MessageType: comment
More information about the Gdb-patches
mailing list