[review v4] Introduce new layout code

[Tom Tromey (Code Review)]

Tom Tromey has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/367
......................................................................


Patch Set 4:

...
> Yeah, so the previous layout is REGS/ASM/CMD split.  When we switch to the previous layout GDB really needs to decrease the size of the CMD window to make space for new window at its minimum size I think.
> 
> Like I said, if you don't think this is worth fixing right now, then just let me know and I'll continue to review as we are right now - the current code already fixes a bunch of issues.

I intentionally made the new layout work as closely to the old layout as I could.
That is, I didn't specifically try to reproduce bad corner cases, but I did 
implement the preserve-the-command-window-height feature.

I suppose we could try a bit harder to handle these cases.  Like, maybe we could do
the layout, then go back and shrink the command window if the height preservation
branch was taken and if there isn't enough room.

In general, though, I think it's fine to just put some of this burden on the user.
Make a funny layout -- get a funny layout.  Or, make the terminal super small,
maybe you'll see nonsense.


-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I3a4cae666327b617d862aaa356f8179f945c6a4e
Gerrit-Change-Number: 367
Gerrit-PatchSet: 4
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-Reviewer: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-Comment-Date: Sun, 24 Nov 2019 18:37:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment