[review v4] gdb: Split print_symbol_info into two parts
Andrew Burgess (Code Review)
gerrit@gnutoolchain-gerrit.osci.io
Fri Nov 22 16:42:00 GMT 2019
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/265
......................................................................
gdb: Split print_symbol_info into two parts
Split the function print_symbol_info into two parts, the new worker
core returns a string, which print_symbol_info then prints. This will
be useful in a later commit when some new MI commands will be added
which will use the worker core to fill some MI output fields.
There should be no user visible changes after this commit.
gdb/ChangeLog:
* symtab.c (symbol_to_info_string): New function, most content
moved from print_symbol_info, but updated to return a std::string.
(print_symbol_info): Update to use symbol_to_info_string and print
returned string.
* symtab.h (symbol_to_info_string): Declare new function.
Change-Id: I6454ce43cacb61d32fbadb9e3655e70823085777
---
M gdb/ChangeLog
M gdb/symtab.c
M gdb/symtab.h
3 files changed, 78 insertions(+), 40 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 4a8bc0f..add7dc7 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,13 @@
2019-11-22 Andrew Burgess <andrew.burgess@embecosm.com>
+ * symtab.c (symbol_to_info_string): New function, most content
+ moved from print_symbol_info, but updated to return a std::string.
+ (print_symbol_info): Update to use symbol_to_info_string and print
+ returned string.
+ * symtab.h (symbol_to_info_string): Declare new function.
+
+2019-11-22 Andrew Burgess <andrew.burgess@embecosm.com>
+
* python/python.c (gdbpy_rbreak): Convert to using
global_symbol_searcher.
* symtab.c (file_matches): Convert return type to bool, change
diff --git a/gdb/symtab.c b/gdb/symtab.c
index f9eddb0..afdbfa7 100644
--- a/gdb/symtab.c
+++ b/gdb/symtab.c
@@ -4710,11 +4710,66 @@
return result;
}
-/* Helper function for symtab_symbol_info, this function uses
- the data returned from search_symbols() to print information
- regarding the match to gdb_stdout. If LAST is not NULL,
- print file and line number information for the symbol as
- well. Skip printing the filename if it matches LAST. */
+/* See symtab.h. */
+
+std::string
+symbol_to_info_string (struct symbol *sym, int block,
+ enum search_domain kind)
+{
+ std::string str;
+
+ gdb_assert (block == GLOBAL_BLOCK || block == STATIC_BLOCK);
+
+ if (kind != TYPES_DOMAIN && block == STATIC_BLOCK)
+ str += "static ";
+
+ /* Typedef that is not a C++ class. */
+ if (kind == TYPES_DOMAIN
+ && SYMBOL_DOMAIN (sym) != STRUCT_DOMAIN)
+ {
+ string_file tmp_stream;
+
+ /* FIXME: For C (and C++) we end up with a difference in output here
+ between how a typedef is printed, and non-typedefs are printed.
+ The TYPEDEF_PRINT code places a ";" at the end in an attempt to
+ appear C-like, while TYPE_PRINT doesn't.
+
+ For the struct printing case below, things are worse, we force
+ printing of the ";" in this function, which is going to be wrong
+ for languages that don't require a ";" between statements. */
+ if (TYPE_CODE (SYMBOL_TYPE (sym)) == TYPE_CODE_TYPEDEF)
+ typedef_print (SYMBOL_TYPE (sym), sym, &tmp_stream);
+ else
+ type_print (SYMBOL_TYPE (sym), "", &tmp_stream, -1);
+ str += tmp_stream.string ();
+ }
+ /* variable, func, or typedef-that-is-c++-class. */
+ else if (kind < TYPES_DOMAIN
+ || (kind == TYPES_DOMAIN
+ && SYMBOL_DOMAIN (sym) == STRUCT_DOMAIN))
+ {
+ string_file tmp_stream;
+
+ type_print (SYMBOL_TYPE (sym),
+ (SYMBOL_CLASS (sym) == LOC_TYPEDEF
+ ? "" : SYMBOL_PRINT_NAME (sym)),
+ &tmp_stream, 0);
+
+ str += tmp_stream.string ();
+ str += ";";
+ }
+ else if (kind == MODULES_DOMAIN)
+ str += SYMBOL_PRINT_NAME (sym);
+
+ return str;
+}
+
+/* Helper function for symbol info commands, for example 'info functions',
+ 'info variables', etc. KIND is the kind of symbol we searched for, and
+ BLOCK is the type of block the symbols was found in, either GLOBAL_BLOCK
+ or STATIC_BLOCK. SYM is the symbol we found. If LAST is not NULL,
+ print file and line number information for the symbol as well. Skip
+ printing the filename if it matches LAST. */
static void
print_symbol_info (enum search_domain kind,
@@ -4741,44 +4796,11 @@
puts_filtered ("\t");
}
- if (kind != TYPES_DOMAIN && block == STATIC_BLOCK)
- printf_filtered ("static ");
-
- /* Typedef that is not a C++ class. */
- if (kind == TYPES_DOMAIN
- && SYMBOL_DOMAIN (sym) != STRUCT_DOMAIN)
- {
- /* FIXME: For C (and C++) we end up with a difference in output here
- between how a typedef is printed, and non-typedefs are printed.
- The TYPEDEF_PRINT code places a ";" at the end in an attempt to
- appear C-like, while TYPE_PRINT doesn't.
-
- For the struct printing case below, things are worse, we force
- printing of the ";" in this function, which is going to be wrong
- for languages that don't require a ";" between statements. */
- if (TYPE_CODE (SYMBOL_TYPE (sym)) == TYPE_CODE_TYPEDEF)
- typedef_print (SYMBOL_TYPE (sym), sym, gdb_stdout);
- else
- type_print (SYMBOL_TYPE (sym), "", gdb_stdout, -1);
- printf_filtered ("\n");
- }
- /* variable, func, or typedef-that-is-c++-class. */
- else if (kind < TYPES_DOMAIN
- || (kind == TYPES_DOMAIN
- && SYMBOL_DOMAIN (sym) == STRUCT_DOMAIN))
- {
- type_print (SYMBOL_TYPE (sym),
- (SYMBOL_CLASS (sym) == LOC_TYPEDEF
- ? "" : SYMBOL_PRINT_NAME (sym)),
- gdb_stdout, 0);
-
- printf_filtered (";\n");
- }
/* Printing of modules is currently done here, maybe at some future
point we might want a language specific method to print the module
symbol so that we can customise the output more. */
- else if (kind == MODULES_DOMAIN)
- printf_filtered ("%s\n", SYMBOL_PRINT_NAME (sym));
+ std::string str = symbol_to_info_string (sym, block, kind);
+ printf_filtered ("%s\n", str.c_str ());
}
/* This help function for symtab_symbol_info() prints information
diff --git a/gdb/symtab.h b/gdb/symtab.h
index 43aa9a9..d4dbc2c 100644
--- a/gdb/symtab.h
+++ b/gdb/symtab.h
@@ -2155,6 +2155,14 @@
(const char *module_regexp, const char *regexp,
const char *type_regexp, search_domain kind);
+/* Convert a global or static symbol SYM (based on BLOCK, which should be
+ either GLOBAL_BLOCK or STATIC_BLOCK) into a string for use in 'info'
+ type commands (e.g. 'info variables', 'info functions', etc). KIND is
+ the type of symbol that was searched for which gave us SYM. */
+
+extern std::string symbol_to_info_string (struct symbol *sym, int block,
+ enum search_domain kind);
+
extern bool treg_matches_sym_type_name (const compiled_regex &treg,
const struct symbol *sym);
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I6454ce43cacb61d32fbadb9e3655e70823085777
Gerrit-Change-Number: 265
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-Reviewer: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-Reviewer: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-CC: Joel Brobecker <brobecker@adacore.com>
Gerrit-MessageType: newpatchset
More information about the Gdb-patches
mailing list