[review v4] [Debugging output] Make remote packet truncation length adjustable

[Luis Machado (Code Review)]

Luis Machado has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/691
......................................................................


Patch Set 4:

(1 comment)

| --- gdb/remote.c
| +++ gdb/remote.c
| @@ -1037,19 +1037,17 @@ /* For "set remote" and "show remote".  */
|  static struct cmd_list_element *remote_set_cmdlist;
|  static struct cmd_list_element *remote_show_cmdlist;
|  
|  /* Controls whether GDB is willing to use range stepping.  */
|  
|  static bool use_range_stepping = true;
|  
|  /* The max number of chars in debug output.  The rest of chars are
|     omitted.  */
|  

PS4, Line 1046:

I took the liberty to make this comment a bit more grammatically
correct...

| -#define REMOTE_DEBUG_MAX_CHAR 512
| -
|  /* Private data that we'll store in (struct thread_info)->priv.  */
|  struct remote_thread_info : public private_thread_info
|  {
|    std::string extra;
|    std::string name;
|    int core = -1;
|  

-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I2e871b37bfcaa6376537c3fe3db8f016dd806a7c
Gerrit-Change-Number: 691
Gerrit-PatchSet: 4
Gerrit-Owner: Luis Machado <luis.machado@linaro.org>
Gerrit-Reviewer: Luis Machado <luis.machado@linaro.org>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-CC: Pedro Alves <palves@redhat.com>
Gerrit-Comment-Date: Thu, 21 Nov 2019 21:49:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Pedro Alves <palves@redhat.com>
Gerrit-MessageType: comment