[review] [Debugging output] Make remote packet truncation length adjustable

[Luis Machado (Code Review)]

Luis Machado has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/691
......................................................................


Patch Set 1:

> Patch Set 1:
> 
> > Patch Set 1:
> > 
> > I'm not too sure packet-length-limit is good. Suggestions are welcome.
> 
> I tend to think something in the "set debug" namespace would be better,
> since it's a setting related to "set debug remote".

I contemplated that, but upon looking at what sorts of options were available via "set debug", they were related to producing debugging output only, not adjusting how the debugging output was produced. So i went for more locality by putting it into "set remote".

To be honest, i don't think it fits in any of those two. But i'm okay with going for "set debug remote-log-length" based on feedback.

> 
> How about "set debug remote-log-length"?
> 
> This patch also needs a documentation change and a NEWS entry.

I'll put something together.


-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I2e871b37bfcaa6376537c3fe3db8f016dd806a7c
Gerrit-Change-Number: 691
Gerrit-PatchSet: 1
Gerrit-Owner: Luis Machado <luis.machado@linaro.org>
Gerrit-Reviewer: Luis Machado <luis.machado@linaro.org>
Gerrit-CC: Tom Tromey <tromey@sourceware.org>
Gerrit-Comment-Date: Wed, 20 Nov 2019 18:41:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment