[review v3] Add maint set/show worker-threads
Christian Biesinger (Code Review)
gerrit@gnutoolchain-gerrit.osci.io
Tue Nov 19 02:57:00 GMT 2019
Christian Biesinger has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/174
......................................................................
Patch Set 3:
(1 comment)
| --- gdb/maint.c
| +++ gdb/maint.c
| @@ -1311,5 +1346,18 @@ When enabled GDB is profiled."),
| maintenance_set_profile_cmd,
| show_maintenance_profile_p,
| &maintenance_set_cmdlist,
| &maintenance_show_cmdlist);
| +
| + add_setshow_zuinteger_unlimited_cmd ("worker-threads",
| + class_maintenance,
| + &n_worker_threads, _("\
| +Set the number of worker threads GDB can use."), _("\
| +Set the number of worker threads GDB can use."), _("\
PS3, Line 1355:
Should this be "Show"? I think this is the cause for the missing T
here:
(gdb) maint show worker-threads
He number of worker threads GDB can use is unlimited.
| +GDB may use multiple threads to speed up certain CPU-intensive operations,\n\
| +such as demangling symbol names."),
| + maintenance_set_worker_threads, NULL,
| + &maintenance_set_cmdlist,
| + &maintenance_show_cmdlist);
| +
| + update_thread_pool_size ();
| }
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I4fb514faa05879d8afe62c77036a4469d57dca2a
Gerrit-Change-Number: 174
Gerrit-PatchSet: 3
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-CC: Christian Biesinger <cbiesinger@google.com>
Gerrit-Comment-Date: Tue, 19 Nov 2019 02:57:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
More information about the Gdb-patches
mailing list