[review v3] First use of tui_layout

[Andrew Burgess (Code Review)]

Andrew Burgess has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/368
......................................................................


Patch Set 3:

I noticed something a little strange, I wonder if this is intended, or an unexpected feature.

I started up a two debug sessions one with current HEAD GDB, and one with your patches up to this point.  Both terminals were 51 tall and 100 wide.  In each session I did:

  gdb TESTFILE
  (gdb) start
  (gdb) tui enable

The first thing I spotted was that the CMD window was different sizes between current HEAD and your patch - this isn't a problem, just an observation.

Then I did:

  (gdb) layout next

In current HEAD notice that the CMD window doesn't change size, while in your patch I am seeing the CMD window get smaller by I think 1 line.

After this:

  (gdb) layout prev

In HEAD again no change in size.  In your patch the CMD window doesn't return back to its original size, it remains at the slightly larger size.

In the previous patch there's a comment about the command window not changing size when the layout changes, which is why this seems so odd.


-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: If1ee06ee58f4803e8c213f4ab0f5bb59f4650ec2
Gerrit-Change-Number: 368
Gerrit-PatchSet: 3
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-CC: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-Comment-Date: Mon, 18 Nov 2019 21:12:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment