[review v10] Update Gnulib to the latest git version

Simon Marchi (Code Review) gerrit@gnutoolchain-gerrit.osci.io
Mon Nov 18 21:10:00 GMT 2019


Simon Marchi has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/681
......................................................................


Patch Set 10: Code-Review+2

Patchset 10 looks good to me.

Note that setting MAKEOVERRIDES to empty disables all the variables passed from top-level, not just CC.  I really don't know if that's an issue or not.  If this causes an issue for somebody, I guess they will speak up.

Since this is quite a big change, can you wait a few days before pushing this to give others a bit of time to try it?


-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I9c2b07a3046baecfb664e21b2644353ea888dbfa
Gerrit-Change-Number: 681
Gerrit-PatchSet: 10
Gerrit-Owner: Christian Biesinger <cbiesinger@google.com>
Gerrit-Reviewer: Christian Biesinger <cbiesinger@google.com>
Gerrit-Reviewer: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Comment-Date: Mon, 18 Nov 2019 21:10:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment



More information about the Gdb-patches mailing list