[review v3] gdb/testsuite: Merge whatis.exp and ctf-whatis.exp

[Andrew Burgess (Code Review)]

Andrew Burgess has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/123
......................................................................


Patch Set 3:

> Patch Set 1: Code-Review+1
> 
> (1 comment)
> 
> Andrew, is there anything holding back this series?  I noted a minor comment, but in general I think it's nice.

I've removed the use of 'rm -fr' from the patch and checked that this makes no difference to the test results even after multiple runs of the test with and without ctf support.  I just copied this code from elsewhere in the testsuite, there was no particular requirement for the removal of the old directory.

If everyone's happy I don't see any reason why this series couldn't be merged.


-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I09e11c70f197b79d2b1e0ae8c86a21c622be6c51
Gerrit-Change-Number: 123
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-Reviewer: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-Reviewer: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-Comment-Date: Mon, 18 Nov 2019 18:06:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment