[review v3] Introduce new layout code

[Tom Tromey (Code Review)]

Tom Tromey has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/367
......................................................................


Patch Set 3:

(1 comment)

| --- /dev/null
| +++ /COMMIT_MSG
| @@ -1,0 +12,21 @@ way, and then be applied by generic code that does not need to know
| +the specifics of every possible layout.
| +
| +This patch itself does not change any behavior, because the new layout
| +engine isn't yet connected to anything.  That is, this merely
| +introduces the implementation.
| +
| +This generic approach makes the code more maintainable.  It also
| +enables some future changes:
| +
| +* New window types are simpler to add;
| +* User-specified layouts are possible; and
| +* Horizontal layouts are more attainable

PS3, Line 23:

FWIW I have patches to do all of these now.  For "new layout
types", the series adds the ability to define a new TUI
window type from Python.

However, these rely on changes in both of the TUI series that
are pending (or would if I cleaned them up), so they'll have
to wait until these all land.

| +
| +gdb/ChangeLog
| +2019-11-12  Tom Tromey  <tom@tromey.com>
| +
| +	* tui/tui-layout.h (class tui_layout_base)
| +	(class tui_layout_window, class tui_layout_split): New.
| +	* tui/tui-layout.c (tui_get_window_by_name)
| +	(tui_layout_window::clone, tui_layout_window::apply)
| +	(tui_layout_window::get_sizes, tui_layout_window::add_split)

-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I3a4cae666327b617d862aaa356f8179f945c6a4e
Gerrit-Change-Number: 367
Gerrit-PatchSet: 3
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-CC: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-Comment-Date: Sun, 17 Nov 2019 21:59:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment