[review] Add no-dist to gnulib configure

[Simon Marchi (Code Review)]

Simon Marchi has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/659
......................................................................


Patch Set 1:

(1 comment)

| --- gnulib/aclocal.m4
| +++ gnulib/aclocal.m4
| @@ -14,19 +14,9 @@ # PARTICULAR PURPOSE.
|  m4_ifndef([AC_CONFIG_MACRO_DIRS], [m4_defun([_AM_CONFIG_MACRO_DIRS], [])m4_defun([AC_CONFIG_MACRO_DIRS], [_AM_CONFIG_MACRO_DIRS($@)])])
|  m4_ifndef([AC_AUTOCONF_VERSION],
|    [m4_copy([m4_PACKAGE_VERSION], [AC_AUTOCONF_VERSION])])dnl
|  m4_if(m4_defn([AC_AUTOCONF_VERSION]), [2.69],,
|  [m4_warning([this file was generated for autoconf 2.69.
|  You have another version of autoconf.  It may work, but is not guaranteed to.
|  If you have problems, you may need to regenerate the build system entirely.
|  To do so, use the procedure documented by the package, typically 'autoreconf'.])])
|  
| -# po.m4 serial 24 (gettext-0.19)

PS1, Line 23:

> So... this change seems unrelated. And unfortunately. when I run aclocal myself, it comes back. Do you have any idea what you did that makes aclocal not insert this block of code? (What's your gettext version?)

I don't see it coming back both when I run the update-gnulib.sh script
and when I run aclocal by hand in

I'm using autoconf and automake I built myself, and gettext 0.20.1
from the distro (Arch, and there doesn't seem to be any patches that
would change this behavior).

Can you give details about your setup so that we can try it our our
side?

| -dnl Copyright (C) 1995-2014, 2016 Free Software Foundation, Inc.
| -dnl This file is free software; the Free Software Foundation
| -dnl gives unlimited permission to copy and/or distribute it,
| -dnl with or without modifications, as long as this notice is preserved.
| -dnl
| -dnl This file can be used in projects which are not available under
| -dnl the GNU General Public License or the GNU Library General Public
| -dnl License but which still want to provide support for the GNU gettext
| -dnl functionality.

-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I5224e18af9acd5284acb79d5756b0e84b00406e9
Gerrit-Change-Number: 659
Gerrit-PatchSet: 1
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-Reviewer: Christian Biesinger <cbiesinger@google.com>
Gerrit-Reviewer: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Comment-Date: Sun, 17 Nov 2019 18:03:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Christian Biesinger <cbiesinger@google.com>
Gerrit-MessageType: comment