[review v2] Import the time_r gnulib module

[Christian Biesinger (Code Review)]

Christian Biesinger has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/613
......................................................................


Patch Set 2:

(1 comment)

| --- gdb/gdbsupport/common-defs.h
| +++ gdb/gdbsupport/common-defs.h
| @@ -91,17 +91,20 @@ #include <stdio.h>
|  #include <stdlib.h>
|  #include <stddef.h>
|  #include <stdint.h>
|  #include <string.h>
|  #ifdef HAVE_STRINGS_H
|  #include <strings.h>	/* for strcasecmp and strncasecmp */
|  #endif
|  #include <errno.h>
|  #include <alloca.h>
| +/* Must be included before pathmax.h.  */
| +#include <time.h>

PS1, Line 101:

A fix has now been committed to gnulib:
https://lists.gnu.org/archive/html/bug-gnulib/2019-11/msg00024.html
http://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=b7bf9f4361c8d78
ccfda7a30ff31f7a406ea972e

I'll look into importing that into gdb.

| +
|  
|  #include "ansidecl.h"
|  /* This is defined by ansidecl.h, but we prefer gnulib's version.  On
|     MinGW, gnulib might enable __USE_MINGW_ANSI_STDIO, which may or not
|     require use of attribute gnu_printf instead of printf.  gnulib
|     checks that at configure time.  Since _GL_ATTRIBUTE_FORMAT_PRINTF
|     is compatible with ATTRIBUTE_PRINTF, simply use it.  */
|  #undef ATTRIBUTE_PRINTF

-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I53fc861b192940d613ca97f2910b4533c730f667
Gerrit-Change-Number: 613
Gerrit-PatchSet: 2
Gerrit-Owner: Christian Biesinger <cbiesinger@google.com>
Gerrit-Reviewer: Christian Biesinger <cbiesinger@google.com>
Gerrit-Reviewer: Pedro Alves <palves@redhat.com>
Gerrit-Comment-Date: Sat, 16 Nov 2019 22:09:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Pedro Alves <palves@redhat.com>
Gerrit-MessageType: comment