[review] Move can_box to tui_gen_win_info

[Andrew Burgess (Code Review)]

Andrew Burgess has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/512
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

Really, really minor nit with the commit message, but otherwise LGTM.  Thanks.

| --- /dev/null
| +++ /COMMIT_MSG
| @@ -1,0 +1,18 @@ 
| +Parent:     d8f6abf8 (Move max_height method to tui_gen_win_info)
| +Author:     Tom Tromey <tom@tromey.com>
| +AuthorDate: 2019-11-05 17:12:04 -0700
| +Commit:     Tom Tromey <tom@tromey.com>
| +CommitDate: 2019-11-06 06:23:33 -0700
| +
| +Move can_box to tui_gen_win_info
| +
| +This moves the can_box method to tui_gen_win_info, so that it will be
| +available for the locator.  This will be used in a subsequent patch.

PS1, Line 10:

It's really minor, but saying "locator" here meant I had to go and dig
through the code to figure out / confirm that this was a reference to
a class.  Could you say "...available in the tui_locator_window
class." or similar.

| +
| +gdb/ChangeLog
| +2019-11-06  Tom Tromey  <tom@tromey.com>
| +
| +	* tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
| +	(struct tui_win_info) <can_box>: Update.
| +
| +Change-Id: Idfa58af41341607932d3c39415f6a35ee9b5d3dc

-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Idfa58af41341607932d3c39415f6a35ee9b5d3dc
Gerrit-Change-Number: 512
Gerrit-PatchSet: 1
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-Reviewer: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-Comment-Date: Wed, 13 Nov 2019 10:18:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment