[review] Import the strerror_r-posix module and use it in GDB.

Simon Marchi (Code Review) gerrit@gnutoolchain-gerrit.osci.io
Wed Nov 6 19:56:00 GMT 2019


Simon Marchi has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/514
......................................................................


Patch Set 1:

(1 comment)

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/514/1//COMMIT_MSG 
Commit Message:

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/514/1//COMMIT_MSG@9 
PS1, Line 9: 
 4 | Commit:     Christian Biesinger <cbiesinger@google.com>
 5 | CommitDate: 2019-11-06 13:31:05 -0600
 6 | 
 7 | Import the strerror_r-posix module and use it in GDB.
 8 | 
 9 > Makes sure to assign the return value of strerror_r to an int,
10 > so that we get a compile error if we accidentally get the
11 > wrong version.
12 | 
13 | gdb/ChangeLog:
14 | 
15 | 2019-11-06  Christian Biesinger  <cbiesinger@google.com>
16 | 

Can you add the same comment in the code?



-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I5cfeb12a5203a4cd94a78581541e6085a68685c3
Gerrit-Change-Number: 514
Gerrit-PatchSet: 1
Gerrit-Owner: Christian Biesinger <cbiesinger@google.com>
Gerrit-CC: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Comment-Date: Wed, 06 Nov 2019 19:56:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment



More information about the Gdb-patches mailing list