[review] Add gdb_compile_openmp to lib/gdb.exp
Pedro Alves (Code Review)
gerrit@gnutoolchain-gerrit.osci.io
Wed Nov 6 16:19:00 GMT 2019
Pedro Alves has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/503
......................................................................
Patch Set 1:
(1 comment)
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/503/1/gdb/testsuite/lib/gdb.exp
File gdb/testsuite/lib/gdb.exp:
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/503/1/gdb/testsuite/lib/gdb.exp@5930
PS1, Line 5930:
5887 | proc build_executable_from_specs {testname executable options args} {
| ...
5925 | } else {
5926 | lappend sources_path "$srcdir/$subdir/$s"
5927 | }
5928 | }
5929 | set ret [gdb_compile_rust $sources_path "${binfile}" $options]
5930 > } elseif [string match gdb_compile_openmp $func] {
5931 > set objects {}
5932 > set i 0
5933 > foreach {s local_options} $args {
5934 > if { ! [regexp "^/" "$s"] } then {
5935 > set s "$srcdir/$subdir/$s"
5936 > }
5937 > if { [$func "${s}" "${binfile}${i}.o" object $local_options] != "" } {
5938 > untested $testname
5939 > return -1
5940 > }
5941 > lappend objects "${binfile}${i}.o"
5942 > incr i
5943 > }
5944 > set ret [$func $objects "${binfile}" executable $options]
5945 > } else {
5946 > set objects {}
5947 > set i 0
5948 > foreach {s local_options} $args {
5949 > if { ! [regexp "^/" "$s"] } then {
5950 > set s "$srcdir/$subdir/$s"
5951 > }
5952 > if { [gdb_compile "${s}" "${binfile}${i}.o" object $local_options] != "" } {
5953 > untested $testname
5954 > return -1
5955 > }
5956 > lappend objects "${binfile}${i}.o"
5957 > incr i
5958 > }
5959 > set ret [$func $objects "${binfile}" executable $options]
5960 > }
5961 | if { $ret != "" } {
5962 | untested $testname
5963 | return -1
5964 | }
5965 |
Testing comment with multiple lines selected.
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I94048b8b0940c707ce0529a6bcfa6e4eace49101
Gerrit-Change-Number: 503
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Buettner <kevinb@redhat.com>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-CC: Pedro Alves <palves@redhat.com>
Gerrit-CC: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Comment-Date: Wed, 06 Nov 2019 16:19:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
More information about the Gdb-patches
mailing list