[review v3] Use strerror_r in safe_strerror if available

[Hannes Domani (Code Review)]

Hannes Domani has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/474
......................................................................


Patch Set 3:

(1 comment)

> Patch Set 1:
> 
> (2 comments)

New build failure for windows.

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/474/3/gdb/gdbsupport/common-utils.h 
File gdb/gdbsupport/common-utils.h:

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/474/3/gdb/gdbsupport/common-utils.h@113 
PS3, Line 113: 
108 | 
109 | /* The strerror() function can return NULL for errno values that are
110 |    out of range.  Provide a "safe" version that always returns a
111 |    printable string.  This version is also thread-safe.  */
112 | 
113 > extern const char *safe_strerror (int);
114 | 
115 | /* Return true if the start of STRING matches PATTERN, false otherwise.  */
116 | 
117 | static inline bool
118 | startswith (const char *string, const char *pattern)

The windows build now fails, because safe_strerror() of mingw-strerror.c doesn't match this prototype anymore:

C:/src/repos/binutils-gdb.git/gdb/gdbsupport/mingw-strerror.c:32:1: error: ambiguating new declaration of 'char* safe_strerror(int)'
   32 | safe_strerror (int errnum)
      | ^~~~~~~~~~~~~
In file included from C:/src/repos/binutils-gdb.git/gdb/gdbsupport/common-defs.h:122,
                 from C:/src/repos/binutils-gdb.git/gdb/gdbsupport/mingw-strerror.c:20:
C:/src/repos/binutils-gdb.git/gdb/gdbsupport/common-utils.h:113:20: note: old declaration 'const char* safe_strerror(int)'
  113 | extern const char *safe_strerror (int);
      |                    ^~~~~~~~~~~~~



-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I81048fbaf148035c221c528727f7efe58ba528eb
Gerrit-Change-Number: 474
Gerrit-PatchSet: 3
Gerrit-Owner: Christian Biesinger <cbiesinger@google.com>
Gerrit-Reviewer: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-CC: Hannes Domani <ssbssa@yahoo.de>
Gerrit-Comment-Date: Fri, 01 Nov 2019 15:21:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment