[review] Make 'target_{short,long}name' inline functions and check if 'current...
Tom Tromey (Code Review)
gerrit@gnutoolchain-gerrit.osci.io
Fri Nov 1 13:18:00 GMT 2019
Tom Tromey has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/481
......................................................................
Patch Set 1:
(1 comment)
Probably Pedro should look at this... I wonder how it interacts with the
multi-remote series.
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/481/1/gdb/testsuite/gdb.tui/segfault-corefile-run.exp
File gdb/testsuite/gdb.tui/segfault-corefile-run.exp:
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/481/1/gdb/testsuite/gdb.tui/segfault-corefile-run.exp@60
PS1, Line 60:
55 |
56 | Term::command "core-file $core"
57 | Term::check_contents "load corefile" "21 *return 0"
58 |
59 | Term::command "run"
60 > Term::check_contents "run until the end" "\\\[Inferior $decimal \\\(process $decimal\\\) exited normally\\]"
This line looks over-long.
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I8a9a4dd6edc3784dc089f37d56f2d020567b4aee
Gerrit-Change-Number: 481
Gerrit-PatchSet: 1
Gerrit-Owner: Sergio Durigan Junior <sergiodj@redhat.com>
Gerrit-CC: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-CC: Tom Tromey <tromey@sourceware.org>
Gerrit-Comment-Date: Fri, 01 Nov 2019 13:18:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
More information about the Gdb-patches
mailing list