Oh dear. I regret to inform you that commit 0e65dfbaf3a0299e4837216a103c28625d4b4f1d might be unfortunate

Nick Alcock nix@esperi.org.uk
Wed May 29 16:04:00 GMT 2019


On 29 May 2019, Rainer Orth told this:
> /vol/src/gnu/gdb/hg/master/local/libctf/ctf-archive.c: In function 'ctf_arc_bufopen':
> /vol/src/gnu/gdb/hg/master/local/libctf/ctf-archive.c:320:33: warning: comparison is always true due to limited range of data type [-Wtype-limits]
>   320 |   if (le64toh (arc->ctfa_magic) != CTFA_MAGIC)
>       |                                 ^~
> /vol/src/gnu/gdb/hg/master/local/libctf/ctf-archive.c: In function 'ctf_arc_open_internal':
> /vol/src/gnu/gdb/hg/master/local/libctf/ctf-archive.c:357:33: warning: comparison is always true due to limited range of data type [-Wtype-limits]
>   357 |   if (le64toh (arc->ctfa_magic) != CTFA_MAGIC)

*Thank* you for this. This revealed significant signedness problems on
32-bit platforms with long <= 32 bits in length, all of which I have now
crushed, to the net benefit of the codebase. :)

Running tests and writing changelogs now.



More information about the Gdb-patches mailing list