[PATCH] Add "thread-exited" annotation

Gary Benson gbenson@redhat.com
Thu May 16 13:14:00 GMT 2019


Hi Amos,

I've only the two nits detailed below, other than those the patch
seems fine.

Cheers,
Gary

Amos Bird wrote:
> diff --git a/gdb/NEWS b/gdb/NEWS
> index 5309a8f923..df5f836bac 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -3,6 +3,8 @@
>  
>  *** Changes since GDB 8.3
>  
> +* 'thread-exited' event is now available in the old annotations interface

I'd lose the "old" here.

> diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
> index 9b0725a033..169b5b8dce 100644
> --- a/gdb/testsuite/ChangeLog
> +++ b/gdb/testsuite/ChangeLog
> @@ -1,3 +1,8 @@
> +2019-04-26  Amos Bird  <amosbird@gmail.com>
> +
> +	* gdb.base/annota1.exp (thread_switch): Test for thread-exited
> +	annotation.
> +

I'd say "Add test..." here.



More information about the Gdb-patches mailing list