[PATCH 3/3] Introduce a separate debug objfile iterator
John Marshall
John.W.Marshall@glasgow.ac.uk
Wed May 15 09:45:00 GMT 2019
On 3 May 2019, Tom Tromey <tom@tromey.com> wrote:
> commit bba6afebd7fde978acb6e06a48084a694aab3b7a
> Author: Tom Tromey <tom@tromey.com>
> Date: Fri May 3 17:21:36 2019 -0600
>
> Remove "struct" from foreach statements
> [snip]
> * darwin-nat.c (thread_info_from_private_thread_info): Remove
> "struct" from foreach.
This broke compilation on macOS (tested on Mojave) with both Clang and GCC (9.1.0):
CXX darwin-nat.o
../../../binutils-gdb/gdb/darwin-nat.c:1709:8: error: must use 'class' tag to refer to type 'thread_info' in this scope
for (thread_info *it : all_threads ())
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/usr/include/mach/thread_act.h:240:15: note:
class 'thread_info' is hidden by a non-type declaration of 'thread_info' here
kern_return_t thread_info
Mach has a thread_info() function declared in that header, which darwin-nat.c #includes.
Cheers,
John
More information about the Gdb-patches
mailing list