[PATCH] Don't crash if dwarf_decode_macro_bytes's 'body' is NULL
Tom Tromey
tom@tromey.com
Wed May 15 01:38:00 GMT 2019
>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes:
Sergio> Sorry, you're right, I left one extra argument there. I was testing the
Sergio> patch on a VM, where I had everything correct, but then I made some
Sergio> extra adjustments and forgot to remove the extra "line == 0 ? _("zero")
Sergio> : _("non-zero")".
Sergio> As for the filename, I was following what other complaints were doing.
I think it's fine to just follow the other ones there.
Sergio> But I also agree that having a filename would be best. What do you
Sergio> think of:
Sergio> complaint (_("debug info gives %s invalid macro definition "
Sergio> "without body (corrupted?) at line %d"
Sergio> "on file %s"),
Sergio> at_commandline ? _("command-line")
Sergio> : _("in-file"),
Sergio> line, current_file->filename);
Sergio> ?
Works for me. This is ok, thanks.
Tom
More information about the Gdb-patches
mailing list