FYI, pushed: [RFA v5] (Ada) Fix frame argument printing when using auto language mode
Joel Brobecker
brobecker@adacore.com
Wed May 8 17:48:00 GMT 2019
Hello everyone,
We just realized that the patch below never got pushed despite
the conditional approval; so I just rebased it, made the required
adjustments, retested it, and then pushed it to master.
Attached is the version that got pushed.
> > gdb/ChangeLog:
> >
> > * ada-valprint.c (ada_val_print_gnat_array): Remove language
> > parameter and use Ada language definition instead.
> > (ada_val_print_ptr): Remove unused language parameter.
> > (ada_val_print_num): Remove language parameter and use Ada language
> > definition instead.
> > (ada_val_print_enum, ada_val_print_flt): Remove unused language
> > parameter.
> > (ada_val_print_struct_union, ada_val_print_ref): Remove language
> > parameter and use Ada language definition instead.
> > (ada_val_print_1): Update all ada_val_print_xxx calls.
>
> You forgot to say that you removed the "language" parameter.
>
> > (ada_val_print): Update ada_val_print_1 call.
> >
> > gdb/testsuite/ChangeLog:
> >
> > * gdb.ada/frame_arg_lang.exp: New testcase.
> > * gdb.ada/frame_arg_lang/bla.adb: New file.
> > * gdb.ada/frame_arg_lang/pck.ads: New file.
> > * gdb.ada/frame_arg_lang/pck.adb: New file.
> > * gdb.ada/frame_arg_lang/foo.c: New file.
>
> This patch is OK for me, modulo the question below. Please give
> everyone who commmented on the patch already a day or two to either
> comment or request more time to comment before you push.
--
Joel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-When-debugging-a-mixed-Ada-C-program-using-this-scen.patch
Type: text/x-diff
Size: 19382 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20190508/effe131d/attachment.bin>
More information about the Gdb-patches
mailing list