[PATCH] gdb/rust: Handle printing structures containing strings

Tom Tromey tom@tromey.com
Thu May 2 15:50:00 GMT 2019


>>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:

>> It took me a while to understand this, but I get it now.  At first it
>> looked like this code was misplaced, but what's going on is that
>> rust_val_print_str only takes a value, so in a "val_print" context we
>> must reconstruct one.

Andrew> If you'd like to suggest some new words I'd be happy to include them.
Andrew> I spent too long trying to write a helpful comment here, and like you
Andrew> I wasn't really happy with what I ended up with....

I think it's fine and it was just me being a bit obtuse :-)

Tom



More information about the Gdb-patches mailing list