[patch, nios2] fix stepping past unwritable kernel helper

Sandra Loosemore sandra@codesourcery.com
Thu Mar 28 16:34:00 GMT 2019


On 3/28/19 5:39 AM, Pedro Alves wrote:
> On 03/28/2019 04:47 AM, Sandra Loosemore wrote:
>> +static int
>> +nios2_linux_is_kernel_helper (CORE_ADDR pc)
>> +{
>> +  return pc == 0x1004;
>> +}
>> +
> 
>> +  /* Returns true if PC points to a kernel helper function.  */
>> +  int (*is_kernel_helper) (CORE_ADDR pc);
> 
> Nit: please make these return bool instead of int.

Thanks for the speedy review.  I've pushed the patch with that tweak as
commit f489207efde922e436b1b420d4de071927e3b9d5.

-Sandra



More information about the Gdb-patches mailing list