[PATCH v2 0/2] Fix build failure with sim-arange inlining

[Stafford Horne]

On Thu, Mar 21, 2019 at 10:17:46PM +0000, Andrew Burgess wrote:
> * Stafford Horne <shorne@gmail.com> [2019-03-17 14:55:34 +0900]:
> 
> > Hello,
> > 
> > On the below I forgot to mention what has changed.  This is mainly a resend, the
> > only change is that I have rebased on the latest master, one of the patches from
> > series one was not longer needed as it fixed by someone else.
> > 
> > Also, ccing Andrew, congrats on being sim maintainer.  Are you also going to be
> > the main contact for cgen?
> 
> Thanks.
> 
> Changes to cgen itself should go to the cgen list
> (cgen@sourceware.org), changes to the cpu files in binutils-gdb are I
> think reviewed through the binutils list.  Then changes to the sim
> making use of the generated sim components are reviewed through the
> gdb list.

Thanks for the review and details, it makes sense.

Sorry, I haven't committed these patches yet. I haven't got the time to sit down
and do it.  Hopefully this weekend.

> Thanks,
> Andrew
> 
> 
> 
> > 
> > -Stafford
> > 
> > 
> > On Sun, Mar 17, 2019 at 06:40:16AM +0900, Stafford Horne wrote:
> > > Hello,
> > > 
> > > When building the OpenRISC sim without CLFAGS set or -O0, I get a failure due to
> > > some bad inlining definitions in sim-arange.  To fix this I have converted
> > > sim-arange inlining to use the more standard sim-inline inlining framework.
> > > This seems to work fine and makes the code a bit easier to follow in my opinion.
> > > 
> > > I have tested this on a few other targets, nios, arm, lm32 etc and it seems to
> > > not break the build or cause issues.
> > > 
> > > During the build I also noticed several other warnings.  Which I think is good
> > > to also fix up so I am including these in the series.
> > > 
> > > Stafford Horne (2):
> > >   sim/common: convert sim-arange to use sim-inline
> > >   sim/common: Fix warnings: "warning: implicit declaration of
> > >     function..."
> > > 
> > >  sim/common/Make-common.in |  3 +--
> > >  sim/common/hw-device.c    |  4 ++++
> > >  sim/common/hw-events.c    |  3 +++
> > >  sim/common/hw-handles.c   |  3 +++
> > >  sim/common/sim-arange.c   | 21 ++++++++++-----------
> > >  sim/common/sim-arange.h   | 30 +++++++++---------------------
> > >  sim/common/sim-base.h     |  1 +
> > >  sim/common/sim-basics.h   |  1 -
> > >  sim/common/sim-fpu.c      |  3 +++
> > >  sim/common/sim-inline.c   |  5 ++++-
> > >  sim/common/sim-inline.h   | 32 ++++++++++++++++++++++++++++++++
> > >  sim/common/sim-options.c  |  2 ++
> > >  sim/common/sim-watch.c    |  2 ++
> > >  13 files changed, 74 insertions(+), 36 deletions(-)
> > > 
> > > -- 
> > > 2.19.1
> > >