[PATCH] gdb/configure.ac: add --enable-source-highlight

Sergei Trofimovich slyfox@gentoo.org
Sun Mar 17 22:47:00 GMT 2019


On Fri, 15 Mar 2019 08:18:42 -0600
Tom Tromey <tom@tromey.com> wrote:

> >>>>> "Sergei" == Sergei Trofimovich <slyfox@gentoo.org> writes:  
> 
> Sergei> Allow disabling source-highlight dependency autodetection even
> Sergei> it exists in the system. More details on problem of automatic
> Sergei> dependencies:
> Sergei> https://wiki.gentoo.org/wiki/Project:Quality_Assurance/Automagic_dependencies  
> 
> Sergei> Noticed by Jeroen Roovers in https://bugs.gentoo.org/680238  
> 
> Hi.  Thank you for the patch.
> 
> This looks essentially fine to me.  Do you have a copyright assignment
> in place?  (Though I wonder whether one is really needed, given that the
> actual change here is pretty small.)

Yes, my company has the assignment. Will resend with according email
address in v2.

> This probably could use some minor follow-on patches, e.g. for "show
> configuration", but I'm happy to do those.

I can have a stab at it as well. Anything else worth adding besides
"show configuration"? I'll send v2 meanwhile.

-- 

  Sergei



More information about the Gdb-patches mailing list