[PATCH][PR gdb/24351] Fix wrong format specification in display_selector()

Simon Marchi simon.marchi@polymtl.ca
Sun Mar 17 18:45:00 GMT 2019


On 2019-03-17 05:48, Владимир Мартьянов wrote:
> There are a wrong format strings in function display_selector() in
> file windows-nat.c. This leads to build error using Cygwin on Windows.
> LDT_ENTRY.HighWord is a DWORD, which is unsigned long int, so the
> format specification should be for long int, not simply int.
> 
> gdb/ChangeLog:
> 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
> 
>     PR gdb/24351
>     * windows-nat.c (display_selector): Format specifications fixed
> 
> Patch and changelog files are attached

Thanks, this LGTM.  I altavista'ed and it looks like this is the right 
thing to do to print DWORDs.  It also builds fine with 
i686-w64-mingw32-gcc and x86_64-w64-mingw32-gcc on Linux.

I tweaked the ChangeLog entry a bit and pushed it.

Simon



More information about the Gdb-patches mailing list