[PATCH] Improve/fix the TUI's current source line highlight

Pedro Alves palves@redhat.com
Fri Mar 15 16:45:00 GMT 2019


On 03/15/2019 04:38 PM, Hannes Domani via gdb-patches wrote:
> Am Donnerstag, 14. März 2019, 18:47:56 MEZ hat Pedro Alves <palves@redhat.com> Folgendes geschrieben: 
> 
>> WDYT?
> 
> The result looks very nice.
> 
> 
>> +/* If true, we're highlighting the current source line in reverse
>> +  video mode.  */
>> +static bool reverse_mode_p = true;
> 
> Shouldn't this variable be initialized to false?
> Weird things happen on my end with true (sometimes the cmd window contents are reversed).
> 

Wow, of course.  I have no idea how I missed that.

> 
> Also, I had to add the following to make it work on windows
> (but beware, I'm using pdcurses, not ncurses, and I don't know if ncurses
> for windows needs this as well):

Thanks, but can you explain it?  It is not obvious to me.

Thanks,
Pedro Alves



More information about the Gdb-patches mailing list