[PATCH v2 04/22] C++ify remote notification code
Tom Tromey
tom@tromey.com
Wed Mar 6 21:12:00 GMT 2019
>> + std::unique_ptr<struct notif_event> event = nc->alloc_event ();
Pedro> "std::unique_ptr<struct notif_event>" appears in a number of places
Pedro> in the patch. Did you consider adding a "notif_event_up" typedef ?
Nope, but I've added it now.
>> -typedef std::unique_ptr<stop_reply, stop_reply_deleter> stop_reply_up;
>> +typedef std::unique_ptr<struct stop_reply> stop_reply_up;
Pedro> Odd that you added the "struct". I tend to remove it when touching
Pedro> code instead. :-)
I changed this back.
Tom
More information about the Gdb-patches
mailing list