[PATCH 1/4] Make "checkpoint" not rely on inferior_ptid

Tom Tromey tom@tromey.com
Tue Mar 5 19:32:00 GMT 2019


>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

Pedro> In the
Pedro> multi-target branch, I'm forcing inferior_ptid to null_ptid early in
Pedro> infrun event handling to make sure we inadvertently rely on the
Pedro> current thread/target when we shouldn't, and that caught some bad
Pedro> or unnecessary assumptions throughout.

This read a bit strangely to me.  Maybe instead write "to make sure we
don't inadvertently rely on the current thread/target,..."?

The patch itself seemed fine to me.  Big +1 to reducing the impact of
globals.

Tom



More information about the Gdb-patches mailing list