[PATCH 2/2] arm-tdep: sort mapping symbols after parsing all minimal symbols

Tom Tromey tom@tromey.com
Tue Jun 25 14:32:00 GMT 2019


>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:

Simon> Somebody on IRC reported a while ago that loading a big ARM program in
Simon> GDB was very slow.  Their profiling pointed out that a big amount of
Simon> time was spent in

Simon>     VEC_safe_insert (arm_mapping_symbol_s, *map_p, idx, &new_map_sym);

Simon> I was able to verify this as well.

Thank you for doing this.  It looks good to me.

Simon>   insert sorted: 71.12s user 2.71s system 99% cpu 1:14.03 total
Simon>   sort after:    46.42s user 2.60s system 99% cpu  49.147 total

Simon> I tried for fun on my Raspberry Pi 3, the run time of
Simon> elf_symtab_read goes from ~259s to ~9s, reading the same file.

Great results.

Tom



More information about the Gdb-patches mailing list