[PATCH 14/66] Introduce has_locator method

Tom Tromey tom@tromey.com
Mon Jun 24 20:50:00 GMT 2019


>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

>> -  int has_locator;		/* Does locator belongs to this window?  */
>> +  bool has_locator;		/* Does locator belongs to this window?  */

Pedro> I'd vote to fix the comment's grammar at the same time.

I did that.

>> +  /* Return true if this window has a locator.  */

Pedro> Should this "a locator" be "the locator", or ...

It should be "the locator", so I made this change.

Tom



More information about the Gdb-patches mailing list